Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readpyaro extension #1124

Merged
merged 8 commits into from
May 23, 2024
Merged

Readpyaro extension #1124

merged 8 commits into from
May 23, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Apr 16, 2024

Adds possibility for extra fields from pyaro.

Is dependent on PRs #1115 and #1102, so they should be merged before this PR

Related issue number

fix #1118

Checklist

@dulte dulte added the enhancement ✨ New feature or request label Apr 16, 2024
@dulte dulte added this to the m2024-06 milestone Apr 16, 2024
@dulte dulte self-assigned this Apr 16, 2024
@dulte
Copy link
Collaborator Author

dulte commented Apr 16, 2024

Tests will fail until metno/pyaro#25 is merged with the pyaro main dev

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (5485b4a) to head (9b4acd6).
Report is 629 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1124      +/-   ##
============================================
+ Coverage     78.75%   78.78%   +0.03%     
============================================
  Files           127      127              
  Lines         20105    20101       -4     
============================================
+ Hits          15833    15836       +3     
+ Misses         4272     4265       -7     
Flag Coverage Δ
unittests 78.78% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dulte dulte requested a review from jgriesfeller April 30, 2024 14:01
Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but please correct the linting

@jgriesfeller jgriesfeller marked this pull request as ready for review May 13, 2024 12:04
@jgriesfeller
Copy link
Member

I took the liberty to finish this up since @dulte is quite busy right now (I need it for some other work). @dulte I'll leave this until tommorrow afternoon in case you want to have a look.

@jgriesfeller jgriesfeller merged commit ca5df29 into main-dev May 23, 2024
8 checks passed
@jgriesfeller jgriesfeller deleted the readpyaro-extension branch May 23, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom metadata to readpyaro
3 participants