Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes colocation setup to use only model kwargs. Adds validator, with test #1184

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Jun 4, 2024

Change Summary

Removes model_read_kwargs from colocation_setup. Now only used model_kwargs. Adds validator for model_kwargs

Related issue number

Fix #1180

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte self-assigned this Jun 4, 2024
@dulte dulte requested a review from lewisblake June 4, 2024 11:33
@dulte dulte added the bug 🐛 Something isn't working label Jun 4, 2024
@dulte dulte added this to the m2024-06 milestone Jun 4, 2024
@dulte
Copy link
Collaborator Author

dulte commented Jun 4, 2024

In the validation of model_kwargs, ValueError can be raised. I did this because it seems that ValidationError can't be raised directly

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (5a686b0) to head (a3e5c8d).
Report is 509 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1184   +/-   ##
=========================================
  Coverage     79.24%   79.25%           
=========================================
  Files           129      129           
  Lines         20213    20220    +7     
=========================================
+ Hits          16018    16025    +7     
  Misses         4195     4195           
Flag Coverage Δ
unittests 79.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake merged commit 3836575 into main-dev Jun 5, 2024
8 checks passed
@lewisblake lewisblake deleted the fix-issue1180 branch June 5, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine model_read_kwargs and model_kwargs in colocation_setup.py
2 participants