Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aerovaldb for writing json in ExperimentOutput #1193

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jun 10, 2024

Change Summary

This PR changes ExperimentOutput to use aerovaldb to write output data from.

Related issue number

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Pin aerovaldb to a fixed tag.
  • Make PR ready to review

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.34%. Comparing base (2dad9c7) to head (816b2cc).
Report is 509 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/experiment_output.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1193      +/-   ##
============================================
+ Coverage     79.32%   79.34%   +0.02%     
============================================
  Files           133      133              
  Lines         20316    20421     +105     
============================================
+ Hits          16115    16204      +89     
- Misses         4201     4217      +16     
Flag Coverage Δ
unittests 79.34% <95.65%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorbjoernl thorbjoernl force-pushed the use-aerovaldb-for-writing-json branch 6 times, most recently from f652e38 to d468f8b Compare June 12, 2024 09:10
@thorbjoernl thorbjoernl changed the title Use aerovaldb for writing json Use aerovaldb for writing json in ExperimentOutput Jun 12, 2024
@thorbjoernl thorbjoernl force-pushed the use-aerovaldb-for-writing-json branch 5 times, most recently from fcd2c37 to 24f44da Compare June 17, 2024 12:01
@thorbjoernl thorbjoernl added this to the m2024-07 milestone Jun 18, 2024
@lewisblake lewisblake modified the milestones: m2024-07, m2024-08 Jun 24, 2024
@thorbjoernl thorbjoernl force-pushed the use-aerovaldb-for-writing-json branch 2 times, most recently from 9b6943d to 8fc78a4 Compare July 3, 2024 12:26
@thorbjoernl thorbjoernl force-pushed the use-aerovaldb-for-writing-json branch from 8fc78a4 to 108f382 Compare July 10, 2024 07:12
@thorbjoernl thorbjoernl force-pushed the use-aerovaldb-for-writing-json branch from 108f382 to 7573a97 Compare July 10, 2024 11:26
@thorbjoernl thorbjoernl marked this pull request as ready for review July 11, 2024 08:14
@thorbjoernl thorbjoernl marked this pull request as draft July 11, 2024 08:44
@thorbjoernl
Copy link
Collaborator Author

thorbjoernl commented Jul 11, 2024

Blocked by: metno/aerovaldb#46

@thorbjoernl thorbjoernl marked this pull request as ready for review July 12, 2024 08:16
@lewisblake lewisblake merged commit d82054d into main-dev Jul 12, 2024
8 checks passed
@lewisblake lewisblake deleted the use-aerovaldb-for-writing-json branch July 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants