Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 70% of rounding performance issue #1278

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Jul 25, 2024

Change Summary

Ensures rounding of stats is performed on numpy arrays instead of iterating over a dict, improving performance.

Related issue number

#1277

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl added the performance 🏎️ Excessive use of time or memory label Jul 25, 2024
@thorbjoernl thorbjoernl added this to the m2024-08 milestone Jul 25, 2024
@thorbjoernl thorbjoernl self-assigned this Jul 25, 2024
@thorbjoernl thorbjoernl requested a review from heikoklein July 25, 2024 07:35
@thorbjoernl thorbjoernl marked this pull request as ready for review July 25, 2024 07:36
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (01a158a) to head (dc40c69).
Report is 384 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1278   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
=========================================
  Files           136      136           
  Lines         20786    20786           
=========================================
  Hits          16431    16431           
  Misses         4355     4355           
Flag Coverage Δ
unittests 79.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@heikoklein heikoklein merged commit ae11096 into main-dev Jul 25, 2024
8 checks passed
@heikoklein heikoklein deleted the improve-rounding-performance branch July 25, 2024 08:07
@lewisblake
Copy link
Member

lewisblake commented Jul 29, 2024

Thing to keep in mind: this approach will not work as intended if the numbers are represented as 32-bit floats. Since they are 64-bit floats, we should be good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 🏎️ Excessive use of time or memory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants