Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQI Check: adjust tolerance again to 1e-3 #1293

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Jul 31, 2024

Change Summary

1e-4 the long run with main_freq=daily crashed CAMS2_83, so adjust tolerance again

Related issue number

NA, see chat

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake requested a review from charlienegri July 31, 2024 09:22
@lewisblake lewisblake added this to the m2024-08 milestone Jul 31, 2024
@lewisblake lewisblake marked this pull request as ready for review July 31, 2024 09:22
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (654afb8) to head (c506a06).
Report is 294 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1293      +/-   ##
============================================
- Coverage     78.96%   78.96%   -0.01%     
============================================
  Files           136      136              
  Lines         20813    20842      +29     
============================================
+ Hits          16436    16458      +22     
- Misses         4377     4384       +7     
Flag Coverage Δ
unittests 78.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake merged commit 1a3c12e into main-dev Jul 31, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the fix-tolerance-1e-3 branch July 31, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants