Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected heatmap data when entire season is full of NaNs #661

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Jun 1, 2022

Correct #658
The heatmap data is basically computed using the same loop as the map data. The fix just moves the resetting of use_dummy into the season loop.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #661 (391b9f7) into main-dev (e8f0c45) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main-dev     #661   +/-   ##
=========================================
  Coverage     76.90%   76.90%           
=========================================
  Files            98       98           
  Lines         17647    17647           
=========================================
  Hits          13571    13571           
  Misses         4076     4076           
Flag Coverage Δ
unittests 76.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/aeroval/coldatatojson_helpers.py 71.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f0c45...391b9f7. Read the comment docs.

@jgriesfeller jgriesfeller requested a review from avaldebe June 1, 2022 09:44
@avaldebe avaldebe marked this pull request as ready for review June 1, 2022 10:01
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ready to merge 🎆

@jgriesfeller jgriesfeller merged commit 82d4333 into main-dev Jun 1, 2022
@jgriesfeller jgriesfeller deleted the griesie_fix_658 branch June 1, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aeroval: heatmap data is also wrong if there's all NaN's in a season (related #639)
2 participants