-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyaeroval cli example #688
Conversation
Codecov Report
@@ Coverage Diff @@
## main-dev #688 +/- ##
=========================================
Coverage 76.81% 76.81%
=========================================
Files 97 97
Lines 17536 17536
=========================================
Hits 13471 13471
Misses 4065 4065
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
detailed explanations of the setup parameters. | ||
detailed explanations of the setup parameters. A configuration could be run as the following:: | ||
|
||
python cfg_example1.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't Daniel mention that we could run a json file also as a config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never seen this done. @dulte?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can run a json file directly. I think you have to read the json as a dict, which can be run. I've did it once when I started working with pyaerocom, but never again, so I don't remember if we did anything smart. But I'm pretty sure you have to make the json file to a python dict first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, thank you. For the purpose of an illustrative example in the documentation, I don't think including this edge case is probably worth it
#670