Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyaeroval cli example #688

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add pyaeroval cli example #688

merged 1 commit into from
Jun 28, 2022

Conversation

lewisblake
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #688 (3014d69) into main-dev (5ce043c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main-dev     #688   +/-   ##
=========================================
  Coverage     76.81%   76.81%           
=========================================
  Files            97       97           
  Lines         17536    17536           
=========================================
  Hits          13471    13471           
  Misses         4065     4065           
Flag Coverage Δ
unittests 76.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce043c...3014d69. Read the comment docs.

@lewisblake lewisblake marked this pull request as ready for review June 27, 2022 12:40
detailed explanations of the setup parameters.
detailed explanations of the setup parameters. A configuration could be run as the following::

python cfg_example1.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't Daniel mention that we could run a json file also as a config file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen this done. @dulte?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you can run a json file directly. I think you have to read the json as a dict, which can be run. I've did it once when I started working with pyaerocom, but never again, so I don't remember if we did anything smart. But I'm pretty sure you have to make the json file to a python dict first

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thank you. For the purpose of an illustrative example in the documentation, I don't think including this edge case is probably worth it

@AugustinMortier AugustinMortier merged commit e9f2666 into main-dev Jun 28, 2022
@lewisblake lewisblake deleted the pya_cli_ex670 branch June 29, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants