Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add StationCoordinateError to exceptions to skip over during obs data reading #737

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

jgriesfeller
Copy link
Member

fixes #652

Verified

This commit was signed with the committer’s verified signature.
…ta reading
@jgriesfeller jgriesfeller self-assigned this Sep 16, 2022
@jgriesfeller jgriesfeller linked an issue Sep 16, 2022 that may be closed by this pull request

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 80.07% // Head: 80.07% // No change to project coverage 👍

Coverage data is based on head (bc03f13) compared to base (86f590d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev     #737   +/-   ##
=========================================
  Coverage     80.07%   80.07%           
=========================================
  Files            92       92           
  Lines         16119    16119           
=========================================
  Hits          12907    12907           
  Misses         3212     3212           
Flag Coverage Δ
unittests 80.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/ungriddeddata.py 69.96% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

# Conflicts:
#	pyaerocom/trends_engine.py
Copy link
Collaborator

@avaldebe avaldebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🎆 ready to merge

@jgriesfeller jgriesfeller merged commit 580facd into main-dev Sep 29, 2022
@jgriesfeller jgriesfeller deleted the griesie_fix_652 branch September 29, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obs data: skip stations that raise StationCoordinateError
2 participants