Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split map files by year #758

Merged
merged 10 commits into from
Oct 26, 2022
Merged

Split map files by year #758

merged 10 commits into from
Oct 26, 2022

Conversation

lewisblake
Copy link
Member

Closing #756

@lewisblake
Copy link
Member Author

Actually splitting by period, which often is a year (e.g., "2010"), but can also be a range of years (e.g., "2010-2020")

@lewisblake lewisblake requested a review from dulte October 24, 2022 14:12
@lewisblake lewisblake marked this pull request as ready for review October 24, 2022 14:13
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 79.83% // Head: 79.35% // Decreases project coverage by -0.47% ⚠️

Coverage data is based on head (fde76db) compared to base (2c80816).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #758      +/-   ##
============================================
- Coverage     79.83%   79.35%   -0.48%     
============================================
  Files            92       92              
  Lines         16200    16203       +3     
============================================
- Hits          12933    12858      -75     
- Misses         3267     3345      +78     
Flag Coverage Δ
unittests 79.35% <100.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/aeroval/glob_defaults.py 100.00% <ø> (ø)
pyaerocom/aeroval/coldatatojson_engine.py 83.63% <100.00%> (+0.30%) ⬆️
pyaerocom/aeroval/coldatatojson_helpers.py 80.32% <100.00%> (ø)
pyaerocom/aeroval/experiment_output.py 70.20% <100.00%> (-15.77%) ⬇️
pyaerocom/aeroval/setupclasses.py 90.16% <0.00%> (-3.28%) ⬇️
pyaerocom/aeroval/collections.py 90.69% <0.00%> (-2.33%) ⬇️
pyaerocom/_lowlevel_helpers.py 82.23% <0.00%> (-0.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dulte
Copy link
Collaborator

dulte commented Oct 25, 2022

Have you tested this for periods of more than one year? E.g. 2010-2020.

@lewisblake
Copy link
Member Author

On the Aeroval side, @AugustinMortier will be testing the results from a run from this afternoon over 2018-2020 using this set up shortly. Perhaps it would be best to wait and see how this change effects the website before merging.

@lewisblake
Copy link
Member Author

@AugustinMortier says it works on the Aeroval side

Copy link
Collaborator

@dulte dulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you can merge :)

@lewisblake lewisblake merged commit 693def7 into main-dev Oct 26, 2022
@lewisblake lewisblake deleted the split-map-files-by-year branch October 26, 2022 13:27
@lewisblake lewisblake restored the split-map-files-by-year branch November 3, 2022 08:18
@lewisblake lewisblake mentioned this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants