Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing temporary path to unpack testdata-minimal.tar.gz #997

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

avaldebe
Copy link
Collaborator

This is likely an error on the underlying library (pooch).
There I create the temporary path before retrieving the test dataset.

close #996

@avaldebe avaldebe self-assigned this Feb 14, 2024
@avaldebe avaldebe requested a review from lewisblake February 14, 2024 12:29
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (4ab7690) 78.94% compared to head (b022199) 78.93%.
Report is 66 commits behind head on main-dev.

Files Patch % Lines
pyaerocom/plugins/icos/reader.py 0.00% 8 Missing ⚠️
pyaerocom/geodesy.py 86.20% 4 Missing ⚠️
pyaerocom/aeroval/coldatatojson_engine.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #997      +/-   ##
============================================
- Coverage     78.94%   78.93%   -0.01%     
============================================
  Files           105      105              
  Lines         18421    18451      +30     
============================================
+ Hits          14543    14565      +22     
- Misses         3878     3886       +8     
Flag Coverage Δ
unittests 78.93% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦸

@lewisblake lewisblake added this to the m2024-03 milestone Feb 14, 2024
@lewisblake lewisblake merged commit ecd8c7b into main-dev Feb 14, 2024
19 of 21 checks passed
@lewisblake lewisblake deleted the issue996 branch February 14, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI crashing due to linters and FileNotFoundError
2 participants