-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run AeroVal experiment from CLI #998
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #998 +/- ##
=========================================
Coverage 78.95% 78.96%
=========================================
Files 105 105
Lines 18478 18500 +22
=========================================
+ Hits 14590 14609 +19
- Misses 3888 3891 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tests for the CLI. What do you think about adding a test for this?
I do not think that running an experiment would work as a test. |
We do have configs which we currently use in CI https://github.com/metno/pyaerocom/blob/main-dev/tests/fixtures/aeroval/cfg_test_exp1.py. Creating a fixture that prevents proc.run() for doing anything could be a good way to test it without adding too much compute time to CI. |
The idea of having a proper command-line interface matches very well the with Usability Guidelines for AeroTools. We haven't decided on a proper configuration-format yet, and json is rather a data-transfer format that a configuration language, in particular since readability is not enforced, and comments are not part of the json standard. |
ff073ed
to
cfc9177
Compare
cfc9177
to
c2de306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄
No description provided.