Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pycodestyle with flake8 #185

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Replace pycodestyle with flake8 #185

merged 3 commits into from
Sep 18, 2020

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented Sep 18, 2020

Other projects related to this one have been moving to using flake8.
This change proposed for the sake of consistency.

@wxtim wxtim self-assigned this Sep 18, 2020
@wxtim wxtim changed the title test with ~~pycodestyle~~ to flake8 Replace pycodestyle with flake8 Sep 18, 2020
@wxtim wxtim mentioned this pull request Sep 18, 2020
2 tasks
@MetRonnie
Copy link
Contributor

Should we add flake8 to

tests_require=['coverage', 'pytest>=5', 'pytest-cov', 'pytest-env'],

@oliver-sanders
Copy link
Member

Yes but I let it slip since pyccodestyle wasn't there before.

If adding it there (good idea) add the tests_require to an all group so we can pip install -e .[all] as with other repos.

@wxtim
Copy link
Contributor Author

wxtim commented Sep 18, 2020

I have now modified setup.py to include flake8 and the option to use pip install -e .[all]

Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Copy link
Contributor

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learnt a thing or two about how pip install works from this 👍

@oliver-sanders
Copy link
Member

Just waiting for tests to pass...

@wxtim
Copy link
Contributor Author

wxtim commented Sep 18, 2020

I learnt a thing or two about how pip install works from this +1

Moi aussi!

@oliver-sanders oliver-sanders merged commit 394d4bb into metomi:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants