Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change next release from 2.1 to 3.0 #205

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

MetRonnie
Copy link
Contributor

@MetRonnie MetRonnie commented Mar 30, 2022

I propose changing the upcoming release from 2.1 to 3.0 due to the breaking changes:

  • Immutability means you can no longer do things like my_timepoint.year += 1
  • Replacement of my_timepoint.get() with properties
  • Improve TimeRecurrence class #183 is sort of like a breaking change

I don't see any reason not to make this a major release. Considering we have been bitten by packages not obeying semver recently (e.g. markupsafe), I think it would be more responsible to make this a major release (even if few people use isodatetime outside of Cylc)

If this is merged I will update the milestone accordingly

@MetRonnie MetRonnie added this to the 2.1 milestone Mar 30, 2022
@MetRonnie MetRonnie self-assigned this Mar 30, 2022
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little dramatic for the scale of changes but ok.

@MetRonnie MetRonnie merged commit ec1a041 into metomi:master Mar 30, 2022
@MetRonnie MetRonnie deleted the changelog branch March 30, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants