Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config edit traceback on page menu. #2137

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

oliver-sanders
Copy link
Member

Steps to replicate:

  1. Open rose edit.
  2. Select rose-suite.conf from the tree menu.
  3. Open the page menu.

@oliver-sanders oliver-sanders added this to the next-release milestone Jan 12, 2018
@oliver-sanders oliver-sanders self-assigned this Jan 12, 2018
@matthewrmshin
Copy link
Member

(Test failure due to change in Travis CI. Fix for the test already proposed in #2132.)

@matthewrmshin
Copy link
Member

@sadielbartholomew please sanity check.

@sadielbartholomew
Copy link
Contributor

sadielbartholomew commented Jan 25, 2018

Yes, I get the traceback:

Traceback (most recent call last):
  File " ... lib/python/rose/config_editor/main.py", line 601, in <lambda>
    self._get_current_page()
  File " ... lib/python/rose/config_editor/menu.py", line 483, in load_page_menu
    add_var_menu = current_page.get_add_menu()
  File " ... lib/python/rose/config_editor/page.py", line 579, in get_add_menu
    named_item.var_id = variable.metadata['id']
AttributeError: 'NoneType' object has no attribute 'var_id'

which disappears with the PR change which solves the error & from looking at the code there should not be any adverse consequences elsewhere either.

@sadielbartholomew sadielbartholomew merged commit 9354464 into metomi:master Jan 25, 2018
@oliver-sanders oliver-sanders deleted the edit-page-bug branch May 18, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants