-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Support non-standard remote run directories. #2252
Conversation
You probably want to concentrate on getting the |
I used new |
Travis CI failure is only because
|
(Tested successfully on two networked VMs, and on the Azure cluster with PBS that mimics the BoM clusters; now awaiting testing at BoM...). |
Yes, attempts to resolve |
I don't really mind either way - given that this logic will migrate to Cylc soon! The |
Just restarted the build again. |
https://www.pygtk.org now points at the PyGObject site. |
@matthewrmshin - I've just retested this again along with cylc/cylc-flow#2877 (i.e. the two parts of cylc/cylc-flow#2779). It all works fine; can you advise on what more needs doing to get this merged to Rose master (specifically tests I guess) and whether next release is feasible. |
os.path.realpath(suite_dir_home) != | ||
os.path.realpath(suite_dir_root)): | ||
if opts.run_dir: | ||
suite_dir_real = os.path.join(suite_dir_root, suite_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewrmshin I believe at this point, suite_dir_root
is Rose config item root-dir
, and suite_name
is appropriately set - however neither of these add {pre,suf}fix 'cylc-run' - so if opts.run_dir is set, suite_dir_real = <rose root-dir>/<suite-name>
(no /cylc-run/ in between) which is then symlinked to ~/cylc-run
which is the exact behaviour I'm seeing.
@hjoliver @DamianAgius If I remember correctly via email exchanges @DamianAgius has a trick in place to make this work at his site. Has/can it be integrated with this branch? |
Sorry for the delay - this all went down while I was away on leave. @DamianAgius - I'm now a bit hazy on the details, except that it seems surprising that this worked properly on the Azure nodes that were supposed to mimic your multi-host configuration. I definitely checked those test results many times and would have noticed if the "cylc-run" path component was missing. Now the Azure nodes have been taken down so I can't retest. I wonder if it was a configuration issue - maybe I (incorrectly?) specified the "cylc-run" path in my home dir config, and you didn't? |
@hjoliver Do you still want to pursue this? |
@matthewrmshin We are running with the locally patched version of Hilary's branch. I currently have no time to spend on this, but would really appreciate the functionality in master (at some stage). My current workload should ease in the coming weeks, and I'll hopefully have some time then. |
As Damian (BoM) notes - yes! |
Next step is, I think, to get feedback from Damian on what was wrong with this branch (causing missing "cylc-run" path component) in his environment, that he managed to fix - when it seemingly wasn't wrong on the simultated environment we had in the cloud ... then I need to figure out how to test it again without said cloud environment ... Docker might save us there. Doesn't sound like a major hurry to get it into master though, from what @DamianAgius says. |
(May have been incorrect use of the path config by one of us, probably me). |
I just rediscovered this ancient PR. @DamianAgius are you still out there? Is this still something you'll need to deal with under Cylc 8 (which is going to be deployed on new hardware, I think?). |
Hi @hjoliver - good to hear from you, and hello to the Cylc/Rose team(s). |
Closing this old PR now, if there's any followup please comment here. |
Works with a non-default cylc global config "run directory" setting, e.g:
This can be useful if, for instance, your
$HOME
on the cylc remote server is not the same as$HOME
on the compute cluster that it fronts (but the compute home dir is still mounted on the remote). We need the suite run directory to be set up where the jobs see it.TODO -
work directory
setting too (for share and work location)root-dir
symlinksroot-dir{share/work}
symlinks--new
(not working?)