Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests broken by cylc/cylc#2781 and cylc/cylc#2849 #2257

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Fix tests broken by cylc/cylc#2781 and cylc/cylc#2849 #2257

merged 1 commit into from
Nov 16, 2018

Conversation

matthewrmshin
Copy link
Member

@matthewrmshin matthewrmshin commented Nov 9, 2018 •
edited
Loading

Suppress debug level log entries in validate commands by not running command in verbose mode.

Modify tests to expect background localhost jobs to store host name entry as hostname -f.

See also: cylc/cylc-flow#2781 and cylc/cylc-flow#2849

@matthewrmshin matthewrmshin added this to the next-release milestone Nov 9, 2018
@matthewrmshin matthewrmshin self-assigned this Nov 9, 2018
@matthewrmshin matthewrmshin mentioned this pull request Nov 9, 2018
Merged
@sadielbartholomew sadielbartholomew mentioned this pull request Nov 9, 2018
Closed
@matthewrmshin matthewrmshin mentioned this pull request Nov 10, 2018
Merged
@matthewrmshin matthewrmshin changed the title Fix tests broken up cylc/cylc#2781 Fix tests broken by cylc/cylc#2781 Nov 12, 2018
@matthewrmshin matthewrmshin changed the title Fix tests broken by cylc/cylc#2781 Fix tests broken by cylc/cylc#2781 and cylc/cylc#2849 Nov 12, 2018
@matthewrmshin
Copy link
Member Author

@sadielbartholomew Please sanity check. This PR fixes the test battery failures that we are currently seeing on master and other PRs.

@matthewrmshin matthewrmshin mentioned this pull request Nov 12, 2018
Merged
sadielbartholomew
sadielbartholomew approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes tests (retaining their rationale) as stated. Approving assuming approach to verbosity change as discussed in the PR comments is agreed.

@oliver-sanders oliver-sanders merged commit b2f48df into metomi:master Nov 16, 2018
@matthewrmshin matthewrmshin deleted the fix-tests-broken-by-cylc-cylc-2781 branch November 16, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
2018.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewrmshin @oliver-sanders @sadielbartholomew