Add a scheduled check that the tests work #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
approved these changes
May 9, 2022
MetRonnie
reviewed
May 9, 2022
| @@ -19,6 +19,8 @@ on: | |||
| cylc_repo: | |||
| description: The Cylc repo to test against | |||
| required: false | |||
| schedule: | |||
| - cron: '37 04 * * 1-5' # 03:37, Monday-Friday | |||
There was a problem hiding this comment.
I thought the idea was to run once or twice a week? Also the comment says 03:37 whereas it is actually 04:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having just discovered that the tests have been failing on master for 19 days since cylc/cylc-flow#4823 was merged I propose the addition of a daily run of the test battery on weekdays so that repository subscribers get to see a problem early.
Given that this is a touch more expensive than the Cylc Rose tests which it is copied from I'd be willing to make it run only on Monday and Thursday mornings, or something like that.