Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests for new cylc install CLI #2588

Merged
merged 3 commits into from
May 10, 2022

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented May 8, 2022

As a result of changes to the Cylc install CLI in cylc/cylc-flow#4823 there are a number of tests with invalid Cylc install options.

This PR attempts to fix these tests.

@wxtim wxtim marked this pull request as draft May 8, 2022 09:35
@wxtim wxtim self-assigned this May 8, 2022
@wxtim wxtim added the bug label May 8, 2022
@wxtim wxtim added this to the 2.0rc3 milestone May 8, 2022
@wxtim
Copy link
Contributor Author

wxtim commented May 8, 2022

All automated tests now passing, though the following are still failing locally for me, this could be setup related:

./t/rose-task-run/34-app-prune-hosts-sharing-fs.t
./t/rose-task-run/42-app-prune-no-rsync.t
./t/rose-host-select/02-localhost.t
./t/rose-task-run/12-app-prune-integer.t
./t/rose-task-run/35-app-prune-log-on-hosts-sharing-fs.t
./t/rose-task-run/06-app-prune-iso.t
./t/rose-app-run/12-file-incr-3.t
./t/rose-host-select/00-basic.t

./t/rosie-lookup/02-unicode.t
./t/rosie-ls/00-basic.t
./t/rosie-lookup/00-basic.t
./t/rosie-lookup/01-multi.t
./t/rosie-ls/01-many.t
./t/rosie-graph/00-basic.t

@wxtim wxtim marked this pull request as ready for review May 8, 2022 10:50
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wxtim. Just needs conflicts resolved.

@wxtim wxtim requested a review from datamel May 10, 2022 09:29
@wxtim wxtim merged commit 3a81dc5 into metomi:master May 10, 2022
@wxtim wxtim deleted the fix_tests_failing_due_to_Cylc_CLI_change branch May 10, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants