Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use any python>=2.7 for rsync check #2611

Merged
merged 3 commits into from
Sep 26, 2022
Merged

use any python>=2.7 for rsync check #2611

merged 3 commits into from
Sep 26, 2022

Conversation

wxtim
Copy link
Contributor

@wxtim wxtim commented Sep 12, 2022

test rsync loc handlers against many python version

closes #2609

@wxtim
use any python>=2.7 for rsync check
b16c67c 
test rsync loc handlers against many python version
dpmatthews
dpmatthews approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
(Note: I haven't reviewed the tests)

@wxtim wxtim mentioned this pull request Sep 14, 2022
Closed
oliver-sanders
oliver-sanders reviewed Sep 14, 2022
View reviewed changes
@wxtim wxtim marked this pull request as draft September 14, 2022 11:48
@wxtim
Copy link
Contributor Author

wxtim commented Sep 14, 2022

Will address comments from Oliver - focusing on rose release

@wxtim wxtim mentioned this pull request Sep 14, 2022
Merged
@wxtim wxtim added this to the 2.0.2 milestone Sep 14, 2022
@wxtim wxtim changed the base branch from master to 2.0.x September 14, 2022 12:42
@wxtim
Merge branch '2.0.x' of github.com:metomi/rose into fix.use_any_pytho…
851d6a7 
…n_for_rsync_check

* '2.0.x' of github.com:metomi/rose:
  allow pre file install check script to be as python version agnostic … (metomi#2612) (metomi#2614)
@wxtim wxtim force-pushed the fix.use_any_python_for_rsync_check branch 8 times, most recently from b29bee8 to dba7daa Compare September 15, 2022 12:41
@wxtim
Copy link
Contributor Author

wxtim commented Sep 15, 2022

Tests running at https://github.com/wxtim/rose/actions/runs/3060531263

@wxtim wxtim marked this pull request as ready for review September 15, 2022 12:43
@wxtim wxtim force-pushed the fix.use_any_python_for_rsync_check branch 3 times, most recently from 0fc40d2 to 23e078e Compare September 15, 2022 12:47
oliver-sanders
oliver-sanders reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:1+:

@wxtim wxtim force-pushed the fix.use_any_python_for_rsync_check branch from ce8f034 to 29c0c67 Compare September 26, 2022 08:53
@oliver-sanders
Copy link
Member

(docs failure unrelated)

@oliver-sanders oliver-sanders self-assigned this Sep 26, 2022
@oliver-sanders oliver-sanders merged commit 5c3af63 into metomi:2.0.x Sep 26, 2022
oliver-sanders pushed a commit to oliver-sanders/rose that referenced this pull request Sep 28, 2022
@wxtim @oliver-sanders
use any python>=2.7 for rsync check (metomi#2611)
726b355 
test rsync loc handlers against many python version
@wxtim wxtim deleted the fix.use_any_python_for_rsync_check branch July 25, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpmatthews dpmatthews dpmatthews approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

rsync handler: reduce dependencies
3 participants
@wxtim @oliver-sanders @dpmatthews