rose date: fix issue when used with integer cycling workflows #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliver-sanders
commented
Feb 1, 2023
oliver-sanders
commented
- Integer is not a valid isodatetime calendar so we shouldn't pass it through as an env var.
- Closes rose date: #2665
oliver-sanders
force-pushed
the
rose-date-integer-fix
branch
from
8cd5f50 to
3b22255
Compare
|
Fixed "install Cylc libs" step in #2667 |
wxtim
approved these changes
Feb 7, 2023
oliver-sanders
requested review from
datamel
and removed request for
MetRonnie
datamel
approved these changes
Feb 7, 2023
* Integer is not a valid isodatetime calendar so we shouldn't pass it through as an env var. * Closes metomi#2665
oliver-sanders
force-pushed
the
rose-date-integer-fix
branch
from
3b22255 to
a30d03d
Compare
|
(rebased) |
|
Letting the tests re-run after the recent fixes, there should still be (I think two) database related failures. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.