Add handling for ROSE_PYTHONPATH #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
feat.ROSE_PYTHONPATH
branch
2 times, most recently
from
4e3f7bd
to
cd10464
Compare
wxtim
force-pushed
the
feat.ROSE_PYTHONPATH
branch
from
cd10464
to
5bfea9d
Compare
| @@ -13,3 +13,5 @@ ignore= | |||
| E731, | |||
| # no longer best practice: | |||
| W503 | |||
| ; module level import not at top of file | |||
| E402, | |||
There was a problem hiding this comment.
Might be able to do this with inline comments rather than globally.
There was a problem hiding this comment.
Was coping the Cylc tox.ini. We don't generally do this, but when we do we usually have our reasons. It's not a fault I think we'll miss.
oliver-sanders
approved these changes
Nov 24, 2023
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
MetRonnie
reviewed
Nov 27, 2023
MetRonnie
reviewed
Nov 28, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
reviewed
Nov 28, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
|
MetRonnie
approved these changes
Nov 28, 2023
wxtim
commented
Nov 30, 2023
MetRonnie
approved these changes
Nov 30, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly the same as cylc/cylc-flow#5727