fix!: mark code, language props as required
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://svelte-highlight-pr-218.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cavekm0nlkiaceib4sj0. |
|
Your Render PR Server URL is https://svelte-highlight-pr-218-hvz0.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cavekmgnlkiaceib4smg. |
metonym
force-pushed
the
prop-semantics
branch
from
a633cb3
to
8db15e9
Compare
metonym
changed the title
code, language props as requiredcode, language props as required
metonym
force-pushed
the
prop-semantics
branch
from
8db15e9
to
fe166a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215
This is technically a breaking change so the major version should be incremented.
This changes the semantics of how
codeandlanguageprops are typed. Both should be required. To do this in Svelte, the props should not be assigned a default value.