Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata in apply-emos-coefficients/sites/additional_predictor files #1596

Closed
MoseleyS opened this issue Oct 25, 2021 · 3 comments · Fixed by #1640
Closed

Fix metadata in apply-emos-coefficients/sites/additional_predictor files #1596

MoseleyS opened this issue Oct 25, 2021 · 3 comments · Fixed by #1640
Assignees
@gavinevans
Labels
FY21/22 Technical Debt Owned by Fiona

Comments

@MoseleyS
Copy link
Contributor

#1591 introduced new acceptance test data that we did not have time to get completely acceptable. A minor change is needed to the title attribute after the release. See this comment for details of the affected files: #1591 (review)

Acceptance criteria:

  • acceptance test data in apply-emos-coefficients/sites do not raise errors in the improver interpret-metadata CLI.
@MoseleyS MoseleyS added the FY21/22 Technical Debt Owned by Fiona label Oct 25, 2021
@gavinevans
Copy link
Contributor

Related to this comment, this issue is dependent on an agreement for the title attribute for the acceptance test data.

@MoseleyS
Copy link
Contributor Author

MoseleyS commented Jan 7, 2022

Related to this comment, this issue is dependent on an agreement for the title attribute for the acceptance test data.

Bruce has confirmed that the correct title attribute for UK Spot data from IMPROVER is 'IMPROVER Post-Processed Multi-Model Blend UK Spot Values'

@gavinevans gavinevans self-assigned this Jan 11, 2022
@gavinevans gavinevans mentioned this issue Jan 11, 2022
Merged
1 task
@gavinevans
Copy link
Contributor

improver PR
#1640

@gavinevans gavinevans removed their assignment Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinevans gavinevans

Labels
FY21/22 Technical Debt Owned by Fiona
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct acceptance test data titles in apply-emos-coefficients/sites gavinevans/improver
2 participants
@MoseleyS @gavinevans