Support providing a static additional predictor when applying EMOS coefficients #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen applying the EMOS coefficients.
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 98.03% 98.05% +0.02%
==========================================
Files 109 109
Lines 9817 9930 +113
==========================================
+ Hits 9624 9737 +113
Misses 193 193
Continue to review full report at Codecov.
|
bayliffe
approved these changes
Oct 25, 2021
MoseleyS
approved these changes
Oct 25, 2021
| a0112b5a48ba99a1a4a345d43b0c453caaf25181504fb9a13786b5722f84cc10 ./apply-emos-coefficients/sites/offset/coefficients.nc | ||
| 22d950494dc9d76d642b0ecc75414e95bfb78fa693e5701fe7cd2fc462a0c6a7 ./apply-emos-coefficients/sites/offset/kgo.nc | ||
| 2722b1d08a87cebf1f36ac914d5badb9af38859b2150da83311dc202ce9be4dd ./apply-emos-coefficients/sites/offset/offset_input.nc | ||
| 3c496867a4a77a4627426b79d8d963a83590b5440984cc2d7a31085cc0efbe10 ./apply-emos-coefficients/sites/percentile_input.nc |
There was a problem hiding this comment.
This file breaks the meta-data convention (title attribute needs "Post-Processed" in the right place)
Comment on lines
+22
to
+24
| e610e4329ef038a5f91e190a3312c24b3e742000a35068268a8c17b9bc83944e ./apply-emos-coefficients/sites/additional_predictor/percentile_kgo.nc | ||
| 60edea7a92af49d6afd10c687fd3f780caa8cd6f8a3bc29d33d5b3e618c949d8 ./apply-emos-coefficients/sites/additional_predictor/probability_kgo.nc | ||
| a3bfead4d08e7ec2ac66067cd16d041b1aabe32eb242f3e072c67efd1d10d8f2 ./apply-emos-coefficients/sites/additional_predictor/probability_template.nc |
There was a problem hiding this comment.
These three files break the meta-data convention (title attributes needs "Post-Processed" in the right place)
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 25, 2021
…lar_ingestion_cli_fp_format * upstream/master: Add CLI for ingesting tabular forecasts and observations into EMOS (metoppv#1592) Support providing a static additional predictor when applying EMOS coefficients (metoppv#1591) Move dataframe to cube utilities (metoppv#1593) Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…efficients (metoppv#1591) * Modifications to add support for passing in an additional predictor when applying the EMOS coefficients. * Add check for a mismatch in sites between the forecast and the additional predictor. * Minor updates following review comments. * Black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1547
Description
This PR adds support for providing a static additional predictor within the apply EMOS CLI. This PR therefore contains updates to the apply EMOS CLI and associated acceptance tests. Updates to the code to separate the additional predictors from the other inputs and updates to the associated unit tests. Minor edits to a few other files, most notably to support using a spot forecast (rather than a gridded forecast) as a probability template.
Testing: