Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constant for ultraviolet_index_daytime_max. #1590

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

Kat-90
Copy link
Contributor

@Kat-90 Kat-90 commented Oct 21, 2021

Addresses #GitHubissuenum

This PR adds a constant for ultraviolet_index_daytime_max so that ECC can find the correct bounds for this chain.
This is related to suite PR: https://github.com/MetOffice/improver_suite/pull/1060

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

CLA

  • If a new developer, signed up to CLA

@Kat-90 Kat-90 added the FY21/22 New Outputs Owned by Stephen with Katie and Kat as a buddies label Oct 21, 2021
@Kat-90 Kat-90 added this to the 1.0.0 milestone Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #1590 (f61a3f7) into master (1cd0489) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         109      109           
  Lines        9782     9782           
=======================================
  Hits         9589     9589           
  Misses        193      193           
Impacted Files Coverage Δ
improver/ensemble_copula_coupling/constants.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd0489...f61a3f7. Read the comment docs.

@bayliffe bayliffe merged commit 555a085 into metoppv:master Oct 25, 2021
gavinevans added a commit to gavinevans/improver that referenced this pull request Oct 25, 2021
…lar_ingestion_cli4

* upstream/master:
  Move dataframe to cube utilities (metoppv#1593)
  Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
gavinevans added a commit to gavinevans/improver that referenced this pull request Oct 25, 2021
…lar_ingestion_cli_fp_format

* upstream/master:
  Add CLI for ingesting tabular forecasts and observations into EMOS (metoppv#1592)
  Support providing a static additional predictor when applying EMOS coefficients (metoppv#1591)
  Move dataframe to cube utilities (metoppv#1593)
  Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY21/22 New Outputs Owned by Stephen with Katie and Kat as a buddies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants