Move dataframe to cube utilities #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependencies between the calibration and ECC code.
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 109 110 +1
Lines 9914 9917 +3
=======================================
+ Hits 9721 9724 +3
Misses 193 193
Continue to review full report at Codecov.
|
2 tasks
bayliffe
requested changes
Oct 25, 2021
improver_tests/calibration/dataframe_utilities/test_dataframe_utilities.py
Outdated
Show resolved
Hide resolved
2 tasks
bayliffe
approved these changes
Oct 25, 2021
Kat-90
approved these changes
Oct 25, 2021
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 25, 2021
…lar_ingestion_cli4 * upstream/master: Move dataframe to cube utilities (metoppv#1593) Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 25, 2021
…lar_ingestion_cli_fp_format * upstream/master: Add CLI for ingesting tabular forecasts and observations into EMOS (metoppv#1592) Support providing a static additional predictor when applying EMOS coefficients (metoppv#1591) Move dataframe to cube utilities (metoppv#1593) Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Move dataframe to cube utilities to a separate file to avoid circular dependencies between the calibration and ECC code. * Minor docstring updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1538
Description
Move the dataframe to cube utilities to a separate file to avoid circular imports between the calibration and ECC code, which causes unexpected import errors.
This was due to a conflict between the lines below, which wasn't picked up in any of the testing of #1582.
To test that the issue has been resolved, try:
Testing: