-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update making a release guidelines #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Codecov Report
@@ Coverage Diff @@
## master #1554 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 106 106
Lines 9463 9463
=======================================
Hits 9268 9268
Misses 195 195 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this update to the release documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
* master: Adds land-mask option to threshold CLI (metoppv#1559) Move statsmodels in environment yml files (metoppv#1556) rearranged args (metoppv#1558) Update Code-Style-Guide.rst (metoppv#1554) Updating timezone cli call (metoppv#1551)
* bayliffe/mobt77: Review changes. Acceptance test added. Add type-hinting throughout. Formatting. Adding unit tests. Grouping solution and rename. First draft of a modal symbol plugin. Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568) Moves position of land-sea-mask in threshold CLI (metoppv#1565) Re-label a diagnostic as a period diagnostic (metoppv#1561) Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550) Adds land-mask option to threshold CLI (metoppv#1559) Move statsmodels in environment yml files (metoppv#1556) rearranged args (metoppv#1558) Update Code-Style-Guide.rst (metoppv#1554) Updating timezone cli call (metoppv#1551)
We jumped the gun a bit, a bit hypocritically, with making the last tag. I've added text to the release process to help us not do that in the future.