Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update making a release guidelines #1554

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

benfitzpatrick
Copy link
Contributor

We jumped the gun a bit, a bit hypocritically, with making the last tag. I've added text to the release process to help us not do that in the future.

Copy link
Contributor

@BelligerG BelligerG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1554 (f87d429) into master (ad48bb7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         106      106           
  Lines        9463     9463           
=======================================
  Hits         9268     9268           
  Misses        195      195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad48bb7...f87d429. Read the comment docs.

Copy link
Contributor

@tjtg tjtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this update to the release documentation.

Copy link
Contributor

@PaulAbernethy PaulAbernethy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@benfitzpatrick benfitzpatrick merged commit 52c9a34 into master Sep 21, 2021
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Sep 23, 2021
* master:
  Adds land-mask option to threshold CLI (metoppv#1559)
  Move statsmodels in environment yml files (metoppv#1556)
  rearranged args (metoppv#1558)
  Update Code-Style-Guide.rst (metoppv#1554)
  Updating timezone cli call (metoppv#1551)
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Oct 5, 2021
* bayliffe/mobt77:
  Review changes. Acceptance test added.
  Add type-hinting throughout.
  Formatting.
  Adding unit tests.
  Grouping solution and rename.
  First draft of a modal symbol plugin.
  Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568)
  Moves position of land-sea-mask in threshold CLI (metoppv#1565)
  Re-label a diagnostic as a period diagnostic (metoppv#1561)
  Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550)
  Adds land-mask option to threshold CLI (metoppv#1559)
  Move statsmodels in environment yml files (metoppv#1556)
  rearranged args (metoppv#1558)
  Update Code-Style-Guide.rst (metoppv#1554)
  Updating timezone cli call (metoppv#1551)
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants