Consolidate scale parameter usage across EMOS and ECC #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 110 110
Lines 10084 10084
=======================================
Hits 9897 9897
Misses 187 187
Continue to review full report at Codecov.
|
fionaRust
reviewed
Jan 17, 2022
doc/source/extended_documentation/calibration/ensemble_calibration/ensemble_calibration.rst
Show resolved
Hide resolved
improver_tests/ensemble_copula_coupling/test_ConvertLocationAndScaleParametersToPercentiles.py
Show resolved
Hide resolved
…e/clarify the usage of the scale parameter.
gavinevans
force-pushed
the
mobt_204_calib_ecc_docs
branch
from
d708451 to
55b5feb
Compare
fionaRust
approved these changes
Jan 18, 2022
bayliffe
approved these changes
Jan 24, 2022
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Jan 31, 2022
* master: Change pandas DataFrame.at to DataFrame.loc (metoppv#1655) MOBT-154: Reunification of wx decision trees (metoppv#1639) Consolidate scale parameter usage across EMOS and ECC (metoppv#1642) # Conflicts: # improver/wxcode/utilities.py
fionaRust
added a commit
to fionaRust/improver
that referenced
this pull request
Feb 23, 2022
…factor_tidy_CLIs * feature_branch_nbhood_refactor: Mobt 157 nbhood refactor consolidate unit tests rebased (metoppv#1664) Mobt 157 nbhood refactor consolidate unit tests part1 (metoppv#1665) Adds a filter to the combine CLI for mismatching realizations (metoppv#1656) Reduce the memory requirements for read-the-docs (metoppv#1672) Further doc-building fixes. (metoppv#1671) DOC Fix intersphinx links for docs (metoppv#1668) Mobt 157 nbhood refactor sort out base classes (metoppv#1653) Modifies wxcode check_tree utility function to report issues with unreachable nodes (metoppv#1637) remove cycle (metoppv#1657) Minor edits to remove raising unnecessary warnings. (metoppv#1646) Change pandas DataFrame.at to DataFrame.loc (metoppv#1655) MOBT-154: Reunification of wx decision trees (metoppv#1639) Consolidate scale parameter usage across EMOS and ECC (metoppv#1642) Adds handling of a model-id-attr to wxcode-modal (metoppv#1634)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Modifications to code, documentation and test, particularly to improve/clarify the usage of the scale parameter. * Update docstrings following review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/204
Description
Modifications to code, documentation and tests, particularly to improve and clarify the usage of the scale parameter. Primarily this involves moving the square rooting of the scale parameter from the ECC code and into the apply EMOS code (specifically the
CalibratedForecastDistributionParametersclass). This is partly to consolidate the squaring and square rooting operations for ease of understanding and maintenance.Testing: