-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polymorphic schemas #1053
Closed
Closed
Polymorphic schemas #1053
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
80b82a3
polymorphic schemas
frenchy64 08e98ec
rm bad section
frenchy64 5ddb951
trim
frenchy64 4463b79
explain requires ifn? not fn?
frenchy64 b3647af
Merge branch 'master' into poly3
frenchy64 d5438b6
sort
frenchy64 db9437e
-vmap
frenchy64 4571be6
use :->
frenchy64 9934fb8
make sure :-> can be generatively tested
frenchy64 f81fa25
document checking
frenchy64 703a024
correctly form schemas with map as first child without props
frenchy64 05188b4
don't allocate seq
frenchy64 f122503
Merge branch 'issue-1070-map-enum-form' into poly3
frenchy64 19100e1
also handle nil enum's, add docs
frenchy64 34c6e09
wording
frenchy64 5da1b7f
use :enum
frenchy64 eb64322
revert enum docs
frenchy64 e5478ee
wording
frenchy64 cdc12dd
Merge branch 'issue-1070-map-enum-form' into poly3
frenchy64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you have three different schemas here? I know the two enums are technically different, but maybe
:nil
,[:enum 50]
and[:map-of :keyword :any]
or something would better clarify what's happening.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it really is this simple, more like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting, okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To go further we'll need to think about what it means to shrink a schema. There are ideas in the spec impl of this, but this is the minimal proof-of-concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will elaborate on exactly what happens in the docs though, thanks for the feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the reason I needed such a convoluted representation in the first place: #1070
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.