Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use private not-found object as .valAt argument #1082

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

alexander-yakushev
Copy link
Contributor

@alexander-yakushev alexander-yakushev commented Aug 2, 2024

Close #1080

As suggested by @frenchy64 in #1079 discussion.

@alexander-yakushev
Copy link
Contributor Author

alexander-yakushev commented Aug 2, 2024

May I also ask for a patch release after this, please? It would be great to test how much the optimization improves things on our side.

@ikitommi ikitommi merged commit 28fea8f into metosin:master Aug 5, 2024
9 checks passed
@ikitommi
Copy link
Member

ikitommi commented Aug 5, 2024

Thanks! patch - you are using leiningen? I can cut out a patch release today.

@alexander-yakushev
Copy link
Contributor Author

I meant a x.y.Z release but any release will do, it doesn't matter :). Thanks!

@ikitommi
Copy link
Member

ikitommi commented Aug 5, 2024

did a new patch release 0.16.3 with this

@ikitommi
Copy link
Member

ikitommi commented Aug 5, 2024

It would be great to test how much the optimization improves things on our side.

Would be happy to hear how this helped.

@alexander-yakushev
Copy link
Contributor Author

Thank you for publishing the release! I've mentioned some of the improvements it brought here: metabase/metabase#46485.

@alexander-yakushev alexander-yakushev deleted the not-found branch August 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:map breaks compositionality of schemas
3 participants