Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charred json formatter module #139

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

nikolap
Copy link
Contributor

@nikolap nikolap commented Nov 18, 2023

This PR adds charred as a JSON encode/decoder module for muuntaja, like cheshire.

The code comes from a private project that uses muuntaja + reitit.

Open to suggestions for how to test and build it locally in the context of this repo, as well as any change requests.

@mvarela
Copy link
Member

mvarela commented Dec 20, 2023

Hi! This looks very good, but it'd need some tests. Would you be able to add those? You can see how the Cheshire integration is tested here https://github.com/metosin/muuntaja/blob/master/test/muuntaja/core_test.clj
For Charred, it'd be essentially the same tests needed.

@nikolap
Copy link
Contributor Author

nikolap commented Dec 20, 2023

Thanks! Do you have any advice for how to run the project locally, i.e. dev setup? This is where I struggled to figure out how to add and run tests.

@mvarela
Copy link
Member

mvarela commented Dec 21, 2023

You can try lein with-profile default,dev repl, which should get you an nREPL server with the dev profile loaded.

@nikolap
Copy link
Contributor Author

nikolap commented Dec 30, 2023

Thanks, that helped me get started. Changes in last commit:

Let me know if anything else seems off!

@mvarela mvarela merged commit cc23871 into metosin:master Mar 15, 2024
@harold
Copy link

harold commented Mar 15, 2024

This is so great! I considered doing this (around the same time that you were actually just doing it, apparently).

With this I think we can perhaps remove cheshire + jsonista and other conflict ridden deps from some of our infrastructure pathways and for that I am grateful. Thanks all! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants