Merge pull request #152 from miikka/fix-fail-on-extra-keys

Make fail-on-extra-keys-transformer work
metosin · Nov 26, 2018 · 11450cd · 11450cd
2 parents 30ecf32 + 5117c0f
commit 11450cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/spec_tools/transform.cljc b/src/spec_tools/transform.cljc
@@ -112,7 +112,7 @@
     x))
 
 ;; TODO: remove this as it couples transformation & validation?
-(defn fail-on-extra-keys [{:keys [keys]} x]
+(defn fail-on-extra-keys [{:keys [::parse/keys]} x]
   (if (and (map? x) (not (set/subset? (-> x (clojure.core/keys) (set)) keys)))
     ::s/invalid
     x))

diff --git a/test/cljc/spec_tools/core_test.cljc b/test/cljc/spec_tools/core_test.cljc
@@ -461,6 +461,9 @@
              (st/select-spec ::person-spec person))))
 
     (testing "failing on extra keys"
+      (is (not (s/invalid? (st/conform ::person
+                                       {:height 200, :weight 80}
+                                       st/fail-on-extra-keys-transformer))))
       (is (s/invalid? (st/conform ::person person st/fail-on-extra-keys-transformer)))
       (is (s/invalid? (st/conform ::person-spec person st/fail-on-extra-keys-transformer))))