Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0: Always use dbname #361

Merged
merged 12 commits into from
Mar 19, 2024
Merged

3.0: Always use dbname #361

merged 12 commits into from
Mar 19, 2024

Conversation

lmangani
Copy link
Collaborator

  • Explicitly use the database name in each query, limit assumed database names or USE statements

lmangani and others added 5 commits October 22, 2023 17:21
@lmangani
Always use db name explicitly
f82c3dc 
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
@lmangani
Use {{DB}} in all queries
a855ba5 
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
@lmangani
Use {{DB}} in all queries
366a36d 
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
@akvlad
#fix: db name substitution
a140ba6
@lmangani
Merge branch 'master' into always-use-dbname
c60ab47 
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
@lmangani lmangani changed the base branch from master to 3.0 October 24, 2023 20:40
@lmangani lmangani requested a review from akvlad October 25, 2023 08:00
@lmangani lmangani changed the title Always use dbname 3.0: Always use dbname Oct 25, 2023
Base automatically changed from 3.0 to master October 30, 2023 09:51
@lmangani
Merge branch 'master' into always-use-dbname
bbe9514 
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
@lmangani
Merge branch 'master' into always-use-dbname
76bc981 
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
@github-actions GitHub Actions
Copy link

Workflow Telemetry - QRYN CI / build (20)

Workflow telemetry for commit 76bc981fc2407c60a752092c88b621caf0345ab9
You can access workflow job details here

Step Trace

gantt
	title build (20)
	dateFormat x
	axisFormat %H:%M:%S
	Set up job : milestone, 1699735958000, 1699735960000
	Initialize containers : 1699735960000, 1699735971000
	Run actions/checkout@v4 : 1699735971000, 1699735974000
	Use Node.js 20 : 1699735974000, 1699735979000
	Run npm install : 1699735980000, 1699735990000
	Run npm run postinstall : 1699735990000, 1699735990000
	Run git submodule init : 1699735991000, 1699735991000
	Run git submodule update : 1699735991000, 1699735992000
	Workflow Telemetry : 1699735992000, 1699735992000
Loading

CPU Metrics

chart_stacked_area_time_00115dc0-112b-4bc8-9274-2e5cab109730

Memory Metrics

chart_stacked_area_time_7a65b642-8dda-43fe-93ab-3015d77fd65a

IO Metrics

Read Write
Network I/O chart_line_time_ec81b5ea-522f-426a-bfc9-042f7a3943a7 chart_line_time_d14eb364-ffb5-4926-bbd2-36ef67dbb6a7
Disk I/O chart_line_time_9f088b71-1006-4f78-9925-60bac466b788 chart_line_time_17178b90-560a-4f78-85cf-7ab63d734b7b

Process Trace

Top 100 processes with highest duration

gantt
	title build (20)
	dateFormat x
	axisFormat %H:%M:%S
	node : crit, 1699735992247, 1699735993285
	npm : crit, 1699735992247, 1699735999395
	node : crit, 1699735992247, 1699735999395
	jest : crit, 1699735992571, 1699735999384
	node : crit, 1699735992571, 1699735999384
	node : 1699735992725, 1699735992773
	find : 1699735993097, 1699735993100
	find : 1699735993109, 1699735993339
	node : 1699735993357, 1699735993435
	node : 1699735993360, 1699735993429
	node : 1699735993363, 1699735993433
	node : 1699735993452, 1699735999370
	node : 1699735993454, 1699735999362
	node : 1699735993457, 1699735999372
	node : 1699735993543, 1699735993591
	node : 1699735993546, 1699735993577
	node : 1699735993555, 1699735993600
Loading

@github-actions GitHub Actions
Copy link

Workflow Telemetry - QRYN CI / build (18)

Workflow telemetry for commit 76bc981fc2407c60a752092c88b621caf0345ab9
You can access workflow job details here

Step Trace

gantt
	title build (18)
	dateFormat x
	axisFormat %H:%M:%S
	Set up job : milestone, 1699735961000, 1699735962000
	Initialize containers : 1699735962000, 1699735977000
	Run actions/checkout@v4 : 1699735978000, 1699735979000
	Use Node.js 18 : 1699735979000, 1699735983000
	Run npm install : 1699735984000, 1699736005000
	Run npm run postinstall : 1699736005000, 1699736006000
	Run git submodule init : 1699736006000, 1699736006000
	Run git submodule update : 1699736006000, 1699736007000
	Workflow Telemetry : 1699736008000, 1699736008000
	Run node qryn.mjs >/dev/stdout & npm run test --forceExit : 1699736008000, 1699736019000
Loading

CPU Metrics

chart_stacked_area_time_dadc029e-458a-40bd-b429-d4ca943a2770

Memory Metrics

chart_stacked_area_time_57c56d83-fdfb-4bfa-b222-48e9f056c86e

IO Metrics

Read Write
Network I/O chart_line_time_a739b81e-143c-42f7-9225-4aa0afb2b2e6 chart_line_time_b7c2c761-23e5-49ff-a948-d54633700f10
Disk I/O chart_line_time_afd18ee9-382a-46e9-a7a0-ba4331a0faec chart_line_time_679764aa-51a4-4f1d-984a-709de265096e

Process Trace

Top 100 processes with highest duration

gantt
	title build (18)
	dateFormat x
	axisFormat %H:%M:%S
	jest : crit, 1699736008959, 1699736019574
	node : crit, 1699736008959, 1699736019574
	node : 1699736009303, 1699736009367
	find : 1699736009750, 1699736009753
	find : 1699736009795, 1699736010393
Loading

@github-actions GitHub Actions
Copy link

Workflow Telemetry - QRYN CI / build (16.x)

Workflow telemetry for commit 76bc981fc2407c60a752092c88b621caf0345ab9
You can access workflow job details here

Step Trace

gantt
	title build (16.x)
	dateFormat x
	axisFormat %H:%M:%S
	Set up job : milestone, 1699735959000, 1699735961000
	Initialize containers : 1699735961000, 1699735976000
	Run actions/checkout@v4 : 1699735976000, 1699735980000
	Use Node.js 16.x : 1699735980000, 1699735986000
	Run npm install : 1699735986000, 1699736005000
	Run npm run postinstall : 1699736005000, 1699736005000
	Run git submodule init : 1699736005000, 1699736005000
	Run git submodule update : 1699736007000, 1699736007000
	Workflow Telemetry : 1699736007000, 1699736007000
	Run node qryn.mjs >/dev/stdout & npm run test --forceExit : 1699736008000, 1699736020000
Loading

CPU Metrics

chart_stacked_area_time_0f19a5c6-426d-46dc-aa9d-0e9f17372708

Memory Metrics

chart_stacked_area_time_f75f7833-e142-4f3f-bdb9-42997a407027

IO Metrics

Read Write
Network I/O chart_line_time_0bd8e064-b815-444f-82ad-8100b3b05b0b chart_line_time_71623056-2a4b-42a5-827a-44cff93a8ab1
Disk I/O chart_line_time_29d750e7-d9f6-4312-b062-2e7b6ccc0ec8 chart_line_time_2d69c891-67bd-421f-a4f6-169ddc628c0b

Process Trace

Top 100 processes with highest duration

gantt
	title build (16.x)
	dateFormat x
	axisFormat %H:%M:%S
	jest : crit, 1699736008130, 1699736020676
	node : crit, 1699736008130, 1699736020676
	node : 1699736008481, 1699736008565
	find : 1699736009111, 1699736009118
	find : 1699736009173, 1699736009921
Loading

@bzed
Copy link

bzed commented Mar 18, 2024

@akvlad a review and merge would be apprciated, working around this issue is rather annoying

@akvlad
Copy link
Collaborator

akvlad commented Mar 18, 2024

@bzed ok.Will merge tomorrow. Thanks for the upvote.

@akvlad
Merge branch 'master' into always-use-dbname
da61867 
# Conflicts:
#	lib/db/clickhouse.js
#	lib/db/maintain/index.js
#	lib/db/maintain/scripts.js
@akvlad
fix: await
c407653
@akvlad
fix: DB.table
6cd25c2
@akvlad akvlad marked this pull request as ready for review March 19, 2024 11:54
@akvlad akvlad merged commit 91a0daf into master Mar 19, 2024
10 checks passed
@akvlad akvlad deleted the always-use-dbname branch March 19, 2024 12:24
@akvlad
Copy link
Collaborator

akvlad commented Mar 19, 2024 •
edited
Loading

@bzed , the PR is reviewed and merged.

@bzed bzed mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akvlad akvlad akvlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmangani @bzed @akvlad