fix: stop the aiohttp app when the metricq HistoryClient is stopped and vice versa #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd vice versa We setup a watchdog that (a)waits for the HistoryClient to stop for whatever reason and then emulates the aiohttp signal handler. If the app is stopped first, this watchdog is cancelled so that we don't get some kind of recursive mess. Also, the on the app cleanup (caused by the signal handler), we properly stop the HistoryClient. This does not deal with any open client connection tasks that may or may not need some extra cancellation.
tilsche
force-pushed
the
aiohttp-metricq-stop-each-other
branch
from
06a7f46 to
7653c02
Compare
bmario
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We setup a watchdog that (a)waits for the HistoryClient to stop for whatever reason and then emulates the aiohttp signal handler.
If the app is stopped first, this watchdog is cancelled so that we don't get some kind of recursive mess.
Also, the on the app cleanup (caused by the signal handler), we properly stop the HistoryClient.
This does not deal with any open client connection tasks that may or may not need some extra cancellation.
This makes #39 obsolete.
The "Graceful" way to stop applications ran by aiohttp seems pretty broken and undocumented (aio-libs/aiohttp#2950). This works, but hopefully some day there will be a better way without having to implement half of aiohttp.