Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tls support optional and add rustls #418

Open
nstinus opened this issue Nov 29, 2023 · 4 comments
Open

Make tls support optional and add rustls #418

nstinus opened this issue Nov 29, 2023 · 4 comments

Comments

@nstinus
Copy link
Contributor

nstinus commented Nov 29, 2023

Tls support was recently added by forcing the usage of openssl via hyper-tls. It means that either this lib is installed or it needs to be compiled. For users unconcerned with tls, we could remove the dependency. Alternatively, rustls provides a pure rust tls implementation.
nstinus added a commit to nstinus/metrics that referenced this issue Nov 29, 2023
@nstinus
Make tls optional and add rustls support (metrics-rs#418)
d38b94e 
BREAKING: tls isn't enabled by default
nstinus added a commit to nstinus/metrics that referenced this issue Nov 29, 2023
@nstinus
Make tls optional and add rustls support (metrics-rs#418)
ded76f0 
BREAKING: tls isn't enabled by default
nstinus added a commit to nstinus/metrics that referenced this issue Nov 30, 2023
@nstinus
Make tls optional and add rustls support (metrics-rs#418)
2ec8df5 
This change removed the required dependency to hyper-tls and openssl.
The allow tls, clients will now have to enable either the `native-tls`
or `rustls-tls` features.

BREAKING: tls isn't enabled by default anymore.
@bushkov
Copy link

bushkov commented Jan 15, 2024

I am also facing an issue because of the added dependency on hyper-tls. I have to cross compile a project to a statically linked binary to be able to run on aarch64-unknown-linux-gnu, which is currently impossible to do with the dependency on hyper-tls added in version 0.13.0 of metrics-exporter-prometheus.

Please switch either to rustls or provide a way to opt out of HTTPS (which would be my preference since I don't need a secure connection for my use case).

@justin13888
Copy link

Are there any plans on moving forward with @nstinus' suggestions? On my end, either switching to rustls and removing hyper-tls outright would be acceptable.

@tobz
Copy link
Member

tobz commented Apr 20, 2024

I left feedback on their PR, which hasn't (yet?) been incorporated. I don't have the time/need to modularize TLS support, so this is waiting on someone to submit a PR doing so, or an update to the aforementioned PR based on my feedback.

@ellie ellie mentioned this issue May 31, 2024
Open
2 tasks
@tessus
Copy link
Contributor

tessus commented May 31, 2024 •
edited
Loading

@tobz if you are ok with switching to rustls, I can create a PR for that. Tomorrow (or actually this evening) that is. It's way past my bedtime. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nstinus @tobz @tessus @bushkov @justin13888