Rework static metric names and add new routing layer #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobz
changed the title
mnpw
pushed a commit
to mnpw/metrics
that referenced
this pull request
Mar 8, 2024
Rework static metric names and add new routing layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the culmination of two changes/bits of functionality: static metric names (no more
NameParts) and a new layer,Router, for routing metrics to certain targets.Admittedly, the bigger change is the reworking of metric names, but we did it in service of the routing layer to make it possible to be faster and have simpler code, and on balance, it seems to be better across the board, performance-wise.