metrics-exporter-prometheus: sanitize matchers the same as input keys #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnpw
pushed a commit
to mnpw/metrics
that referenced
this pull request
Mar 8, 2024
…her_fix metrics-exporter-prometheus: sanitize matchers the same as input keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #173, which is related to the mismatch/ergonomics of how matchers are used against metric keys.
Now, we ensure that matchers are "sanitized" in the same way we sanitize keys to match the Prometheus restrictions. In addition, we've also improved the key sanitation. While the previous sanitizer code dealt with known issues, the new code is closer to the actual specification for what a Prometheus metric name can be.