Use portable-atomic
only for 32-bit architectures
#347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new take on how to use the atomics without bringing in the
portable-atomic
crate for 64-bit architectures where one can use juststd
.Believe this approach could satisfy the requirements, and be easier to use for everyone, but I'm not super familiar with this crate so may have missed something also.
Resolves #346
Resolves #323
Changed
portable_atomic::AtomicU64
for 32-bit platforms, for 64-bit platforms use std.Added
AtomicU64
so one have an easy and convenient way to get the used atomic counter type regardless if one 32-bit or 64-bit architectures and without depending on external crates when using this crate.Removed
std-atomics
Cargo feature as it is not longer needed