Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permit trailing commans in describe macros #483

Merged

Conversation

SuperFluffy
Copy link
Contributor

This patch allows trailing commas in all describe*! macros, similar to the gauge!, histogram!, and count! macros. Just a minor quality of life improvement.

@tobz tobz added C-macros Component: macros. E-simple Effort: simple. T-ergonomics Type: ergonomics. labels May 9, 2024
@tobz
Copy link
Member

tobz commented May 9, 2024

Looks good to me! 👍🏻

@tobz tobz merged commit ce9084b into metrics-rs:main May 9, 2024
12 checks passed
@tobz tobz added the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label May 9, 2024
@SuperFluffy SuperFluffy deleted the permit_trailing_comma_in_describe_macros branch May 9, 2024 18:47
@tobz
Copy link
Member

tobz commented May 27, 2024

Released in metrics@v0.23.0.

Thanks again for your contribution. 🙏🏻

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-macros Component: macros. E-simple Effort: simple. T-ergonomics Type: ergonomics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants