Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation docs #123

Merged
merged 2 commits into from
Apr 15, 2022
Merged

validation docs #123

merged 2 commits into from
Apr 15, 2022

Conversation

barrettk
Copy link
Contributor

  • Pull stories from github milestones
  • assign test ids to all tests (update test files)
  • create stories yaml file from github milestone tests only
  • create validation docs from stories yaml

@barrettk
Copy link
Contributor Author

barrettk commented Apr 12, 2022

FYI
image

Will look into this after I go though the other packages.
Here are all the tests (that ran):

> as.data.frame(test_res)
                                                   TestName passed failed        TestId
1                                 axis labels are generated      2      0 YSP-TEST-0001
2                             axis col-labels are generated      2      0 YSP-TEST-0002
3                                axis col-labels title case      2      0 YSP-TEST-0003
4                                 axis col-labels short max      2      0 YSP-TEST-0004
5                                      take axis info as-is      1      0 YSP-TEST-0005
6                                 axis lab is in title case      2      0 YSP-TEST-0006
7                               axis lab has limited length      2      0 YSP-TEST-0007
8            put character columns last, except comment_col      2      0 YSP-TEST-0008
9                             factor is generated from spec      2      0 YSP-TEST-0020
10                     factor is generated from ycol object      2      0 YSP-TEST-0021
11                 error making factor from continuous data      1      0 YSP-TEST-0022
12                                         make all factors      2      0 YSP-TEST-0023
13                 ys_add_factors aliases yspec_add_factors      1      0 YSP-TEST-0024
14                            NA handling by ys_add_factors      2      0 YSP-TEST-0025
15                OK to have missing or extra cols in .data      3      0 YSP-TEST-0026
16 tidyselect semantics when identifying columns for factor      4      0 YSP-TEST-0027
17                                         control defaults      7      0 YSP-TEST-0028
18                                 wrong types are detected      3      0 YSP-TEST-0029
19                                  values eq decode output      2      0 YSP-TEST-0030
20                                                   define      2      1 YSP-TEST-0031
21                                mrgtemplate is deprecated      1      0 YSP-TEST-0032
22                      definetemplate replaces mrgtemplate      2      0 YSP-TEST-0033
23                                             load_spec_ex      0      2 YSP-TEST-0034
24                                             load_proj_ex      2      0 YSP-TEST-0035
25                                 load spec with extension      2      2 YSP-TEST-0036
26                                    extend a yspec object      0      1 YSP-TEST-0037
27        extension fails when extension file doesn't exist      1      0 YSP-TEST-0038
28                                               fda_define      1      0 YSP-TEST-0039
29              data_stem is respected in regulatory define      3      0 YSP-TEST-0040
30                                     set flags in SETUP__      8      0 YSP-TEST-0041
31                           flags error when col not found      1      0 YSP-TEST-0042
32                   flags - warn when exists and overwrite      1      0 YSP-TEST-0043
33                    flags are propagated from lookup file      4      0 YSP-TEST-0044
34                               TeX code is properly glued      1      0 YSP-TEST-0045
35                                      handle value:decode      0      1 YSP-TEST-0046
36                                            decode_values      3      1 YSP-TEST-0047
37                                      assets are exported      2      0 YSP-TEST-0048
38                                     help object printing     10      0 YSP-TEST-0049
39                      (code run outside of `test_that()`)      0      1          <NA>

@barrettk
Copy link
Contributor Author

The test issues described above were a function of this bug, and have now been addressed.

@barrettk barrettk merged commit 7021a76 into develop Apr 15, 2022
@kylebaron kylebaron mentioned this pull request May 10, 2022
@kylebaron kylebaron deleted the feat/validation_docs branch July 25, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants