Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Null Campaign Content #34

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Conversation

joshuafranks
Copy link
Contributor

Description

This PR introduces a fix for mettle/sendportal#47.

Joshua Franks added 2 commits June 22, 2020 17:30
/** @test */
function it_can_handle_a_null_value_for_campaign_content()
{
$content = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this variable is unused.

Copy link
Contributor

@JonoB JonoB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but check @mauricius comment pls @joshuafranks

@dljfield dljfield merged commit 1ad6054 into master Jul 10, 2020
@dljfield dljfield deleted the bugfix/null-campaign-content branch July 10, 2020 09:46
@JonoB JonoB added this to the v1.0.3 milestone Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants