Fix behavior with header X-Forward-HTTPS: off #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case the internal scheme in Apache was set unconditionally (the mere presence of the header is treated as if it's value was always 'on'). This affects e.g. the DirectorySlash Redirect in mod_dir (the one adding trailing slashes) and leads to redirects like this: http://host.name/foo -> https://host.name:80/foo/ when the initial request contained a header X-Forwarded-HTTPS: off or X-HTTPS: off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case the internal scheme in Apache was
set unconditionally (the mere presence of the
header is treated as if it's value was always 'on').
This affects e.g. the DirectorySlash Redirect in
mod_dir (the one adding trailing slashes)
and leads to redirects like this:
http://host.name/foo -> https://host.name:80/foo/
when the initial request contained a header
X-Forwarded-HTTPS: off
or
X-HTTPS: off