Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in arch string description #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Millak
Copy link

@Millak Millak commented Jan 5, 2023

No description provided.

@mewmew
Copy link
Member

mewmew commented Jan 5, 2023

Thanks for the PR @Millak.

I think lower-case i386 is also in use? At least according to Wiki. From https://en.wikipedia.org/wiki/I386:

The Intel 386, originally released as 80386 and later renamed i386, is a 32-bit microprocessor introduced in 1985

@Millak
Copy link
Author

Millak commented Jan 5, 2023

That was my first thought, but then I saw http://msdn.microsoft.com/en-us/gg463119.aspx from pe.go which has IMAGE_FILE_MACHINE_I386 and I wasn't sure if you used AMD64 and IA64 because those ones are normally capitalized or because that's how Microsoft's documentation has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants