-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker file for CSSIFY #23
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPatel33 , please do not commit the package-lock.json from the commit.
And can you show the POC maybe like a gif that the dockerfile is working?
@ShubhamPatel33 , i was referring to this one: client/package-lock.json |
Okay,is it fine now, only gif remaining,correct ? |
Yes, @ShubhamPatel33 . Even a simple video would suffice. |
Created a small video how one can start the docker and have fun with it . Uploading demo_dockerfile.mp4… |
demo_dockerfile.mp4 |
@ShubhamPatel33 , good work! But this is not what I was looking for. By deployment, we are looking to expose the port locally. You'd have to do more work in this PR and create a way so that you can read access the port through your localhost. |
Is it similar to this answer ? |
Thanks |
Updating the video by the docker build and run command. docker_final.mp4 |
Looks good! |
@@ -13,7 +13,7 @@ | |||
"react": "^16.13.1", | |||
"react-bootstrap": "^1.0.1", | |||
"react-dom": "^16.13.1", | |||
"react-scripts": "^3.4.4", | |||
"react-scripts": "^4.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change tho?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were automatically been made while making the docker file
backend/package.json
Outdated
@@ -25,6 +25,7 @@ | |||
"helmet": "^3.22.0", | |||
"node-sass": "^4.14.1", | |||
"node-sass-json-importer": "^4.3.0", | |||
"socket.io": "^3.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were automatically been made while making the docker file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamPatel33, please remove the socket io dependency as it is not required. And sorry for the slow reviews, have been a little occupied lately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the socket.io,will it gonna count in Mwoc as the PR was made in the mentioned date and the changes took some time .
All looks good, please do these minor tweaks before we merge it. |
Thanks, finally it will be merged . |
issue #5
Description
I have created a docker file for CSSIFY with NOde version of 14 which is compatible for the project.
Motivation and Context
How Has This Been Tested?
The file was successfully built and no errors were generated.
Screenshots (if appropriate):
Types of changes
Checklist: