Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean repo #37

Merged
merged 13 commits into from
Nov 18, 2024
Merged

Clean repo #37

merged 13 commits into from
Nov 18, 2024

Conversation

ethanhung11
Copy link
Collaborator

@ethanhung11 ethanhung11 commented Nov 16, 2024

Removing unused files & combining where possible. Branch is behind main & does not the ALS/CLS line search changes.

@ethanhung11 ethanhung11 added the cleaning 🧹 label Nov 16, 2024
@ethanhung11 ethanhung11 requested a review from aarmey November 17, 2024 17:17
Copy link
Member

@aarmey aarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you handle the merge conflicts?

@ethanhung11
Copy link
Collaborator Author

Should be fixed now!

Copy link
Member

@aarmey aarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things.

timpute/figures/common.py Outdated Show resolved Hide resolved
timpute/figures/figure3.py Outdated Show resolved Hide resolved
@ethanhung11 ethanhung11 requested a review from aarmey November 18, 2024 21:42
Copy link
Member

@aarmey aarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Merging.

@aarmey aarmey merged commit 51a5f2a into main Nov 18, 2024
1 check passed
@aarmey aarmey deleted the clean-repo branch November 18, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants