Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PARAFACM code #40

Merged
merged 8 commits into from
Nov 23, 2024
Merged

Add PARAFACM code #40

merged 8 commits into from
Nov 23, 2024

Conversation

ethanhung11
Copy link
Collaborator

No description provided.

@ethanhung11 ethanhung11 requested a review from aarmey November 20, 2024 01:25
aarmey
aarmey reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@aarmey aarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run this, are you seeing that it imputes fairly well? This is a good test of correctness to start.

@ethanhung11
Copy link
Collaborator Author

ethanhung11 commented Nov 22, 2024 •
edited
Loading

It imputes as expected. After running more general tests, C-ALS isn't universally better. At higher components, PARAFAC-M occasionally remains stable where C-ALS doesn't.
*Note: I used a smaller N=5 (random initialization) & only looked at the 10% case for now

@aarmey
Copy link
Member

aarmey commented Nov 23, 2024

Ok, good. Sounds like the line search may end up being helpful to include. Merging.

@aarmey aarmey merged commit b69facf into main Nov 23, 2024
1 check passed
@aarmey aarmey deleted the PARAFACM branch November 23, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarmey aarmey aarmey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanhung11 @aarmey