Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid namespace ambiguity #2

Open
wants to merge 1 commit into
base: fix-1343-melodic-devel-3
Choose a base branch
from

Conversation

Felix-El
Copy link

Hi,

thanks for sharing the patch. I'm trying it locally.

However, I've faced issues compiling one existing node with the patched roscpp: the node defines a time_point at global scope and later, when condition_variable.h is included through a chain of other include files, we have an ambiguity there.

It sure is not good practice to have stuff at global scope but still, to avoid the issue for others, I'd propose to get rid of 'using namespace boost::chrono;' in favor of a namespace alias.

Guess I just learned that even scoped 'using namespace ...' is not great for use in header files, since the environment we're compiling in is controlled by the includer.

Best Regards

-Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant