-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum supported PHP version, add allowed plugins #33
Update minimum supported PHP version, add allowed plugins #33
Conversation
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Psalm will fail with the following still, but I'm unsure right now how to address them:
We may need to add better types to |
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Baseline additions would suffice at first, perhaps? |
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
…onfiguration Signed-off-by: Gary Lockett <gary@creativecow.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
This PR:
phpunit/phpunit
to~2.4.0
as the XSD is required by CI