Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported PHP version, add allowed plugins #33

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Update minimum supported PHP version, add allowed plugins #33

merged 6 commits into from
Sep 14, 2022

Conversation

internalsystemerror
Copy link
Member

@internalsystemerror internalsystemerror commented Sep 13, 2022

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This PR:

  • Updates the minimum supported PHP version to 7.4
  • Adds allowed plugins to fix the issues brought up by Configure Renovate #32
  • Updates phpunit/phpunit to ~2.4.0 as the XSD is required by CI

Gary Lockett added 2 commits September 14, 2022 00:20
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror
Copy link
Member Author

Psalm will fail with the following still, but I'm unsure right now how to address them:

ERROR: MixedArgumentTypeCoercion - src/PhpSessionPersistence.php:112:28 - Argument 1 of Mezzio\Session\Session::__construct expects array<string, mixed>, but parent type array<array-key, mixed> provided (see https://psalm.dev/194)
return new Session($_SESSION ?? [], $sessionId);

ERROR: MixedArgumentTypeCoercion - src/PhpSessionPersistence.php:159:36 - Argument 1 of Mezzio\Session\Session::__construct expects array<string, mixed>, but parent type array<array-key, mixed> provided (see https://psalm.dev/194)
$session = new Session($session->toArray(), $this->generateSessionId());

The type of $session->toArray() is sourced from here - vendor/mezzio/mezzio-session/src/SessionInterface.php:12:32
public function toArray(): array;

We may need to add better types to mezzio/mezzio-session.

Signed-off-by: Gary Lockett <gary@creativecow.uk>
@Ocramius
Copy link
Member

Baseline additions would suffice at first, perhaps?

@Ocramius Ocramius added this to the 1.13.0 milestone Sep 14, 2022
@Ocramius Ocramius added Enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 14, 2022
src/ConfigProvider.php Outdated Show resolved Hide resolved
Gary Lockett added 3 commits September 14, 2022 17:39
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
…onfiguration

Signed-off-by: Gary Lockett <gary@creativecow.uk>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Sep 14, 2022
@Ocramius Ocramius merged commit 7be90ae into mezzio:1.13.x Sep 14, 2022
@internalsystemerror internalsystemerror deleted the update-composer-configuration branch September 14, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants