-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 support #38
PHP 8.0 support #38
Conversation
Failing tests are caused be PHP 8 incompatible third-party libraries:
How would you like to proceed? |
colors="true"> | ||
<testsuites> | ||
<testsuite name="default"> | ||
<directory suffix="Test.php">test</directory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suffix
attribute can be omitted because it is redundant with the value Test.php
.
Both libraries have issue reports and pull requests for the topic PHP 8 but so far none release. auryn
PHP-DIThe first step would be to ask with the note that the support for PHP 8 is needed in Mezzio. So far, it has worked quite well for other components. |
There are some PRs merged in Auryn, maybe the tests for that are now passing. We might want to add a NOTE that some dependencies (selections) might not work on PHP 8 and thus has to be found out by the users. Unless they use |
I restarted travis CI |
Just stumbled on this, FYI both issues linked for PHP-DI are not related I think. PHP-DI 6 (current stable) supports PHP 8. If there's an issue, let me know. |
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Use local XML schema description file Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
…troduced in chubbyphp/chubbyphp-container 1.3 which now returns an instance of MinimalContainer Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
…ation Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Closes #37