Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 support #38

Merged
merged 8 commits into from
May 10, 2021
Merged

PHP 8.0 support #38

merged 8 commits into from
May 10, 2021

Conversation

arueckauer
Copy link
Contributor

Closes #37

@arueckauer
Copy link
Contributor Author

Failing tests are caused be PHP 8 incompatible third-party libraries:

  • auryn on PHP 8.0 lowest and latest
  • PHP-DI on PHP 8.0 lowest

How would you like to proceed?

colors="true">
<testsuites>
<testsuite name="default">
<directory suffix="Test.php">test</directory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suffix attribute can be omitted because it is redundant with the value Test.php.

@froschdesign
Copy link
Member

@arueckauer

Failing tests are caused be PHP 8 incompatible third-party libraries:

  • auryn on PHP 8.0 lowest and latest
  • PHP-DI on PHP 8.0 lowest

How would you like to proceed?

Both libraries have issue reports and pull requests for the topic PHP 8 but so far none release.

auryn

PHP-DI

The first step would be to ask with the note that the support for PHP 8 is needed in Mezzio. So far, it has worked quite well for other components.

@boesing
Copy link
Member

boesing commented Jan 1, 2021

There are some PRs merged in Auryn, maybe the tests for that are now passing.
Since this package is fully PHP 8.0 compliant, I would say this PR could be merged.

We might want to add a NOTE that some dependencies (selections) might not work on PHP 8 and thus has to be found out by the users.

Unless they use composer create-project --ignore-platform-reqs, composer should comply that incompatible packages cannot be installed anyways.

@samsonasik
Copy link
Member

I restarted travis CI

@mnapoli
Copy link

mnapoli commented Apr 17, 2021

Just stumbled on this, FYI both issues linked for PHP-DI are not related I think.

PHP-DI 6 (current stable) supports PHP 8. If there's an issue, let me know.

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Use local XML schema description file

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
…troduced in chubbyphp/chubbyphp-container 1.3 which now returns an instance of MinimalContainer

Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
Signed-off-by: Andi Rückauer <arueckauer@gmail.com>
@weierophinney weierophinney added this to the 3.8.0 milestone May 10, 2021
@weierophinney weierophinney added the Enhancement New feature or request label May 10, 2021
…ation

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit 56764ae into mezzio:3.8.x May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
6 participants