Remove unnecessary size check on static files #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks serving 0-byte files where only the file name is significant, such as those used in HTTP challenges for domain verification, SSL cert issuance, etc. Signed-off-by: Roy-Orbison <Roy-Orbison@users.noreply.github.com>
|
As a reference, according to apache docs, this change makes sense: |
geerteltink
approved these changes
Feb 5, 2021
|
If this proposal accepted then we need also an update on laminas-mvc-skeleton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks serving 0-byte files where only the file name is significant, such as those used in HTTP challenges for domain verification, SSL cert issuance, etc.
Description
This was a fix to a downstream issue (shlinkio/shlink#988) due to which Let's Encrypt SSL certificates failed to issue/renew on Litespeed Web Server (an Apache-compatible server).